Skip to content

Restore regular unsplatted arguments for open3 subprocess #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanschlue-as merged 2 commits into from
Jul 20, 2021
Merged

Restore regular unsplatted arguments for open3 subprocess #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a40432c
Restore regular unsplatted arguments for open3 subprocess
jonathanschlue-as Jul 19, 2021
2b0eb53
Specs: Remove unnecessary block argument
jonathanschlue-as Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/check-minio-update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def get_latest_version(checkurl, platform)
end

def get_local_version
stdout, stderr, status = Open3.capture3([{'PATH' => ENV['PATH']}, 'minio --version', :unsetenv_others => true])
stdout, stderr, status = Open3.capture3({ 'PATH' => ENV['PATH'] }, 'minio --version', :unsetenv_others => true)

raise IOError, "Unable to gather local minio version: #{stderr}" unless status.success?

Expand Down
5 changes: 2 additions & 3 deletions spec/check-minio-update_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
before do
stub_checksum_request
allow(check).to(receive(:output))
allow(Open3).to(receive(:capture3).with(array_including('minio --version'))
.and_return([stdout, stderr, double(:success? => success)]))
allow(Open3).to(receive(:capture3).and_return([stdout, stderr, double(:success? => success)]))
end

let(:checksum_request) do
Expand Down Expand Up @@ -81,7 +80,7 @@
end
end

context 'with release url not found' do ||
context 'with release url not found' do
let(:response) { { body: '404 Not Found', status: 404 } }

it 'should be unknown' do
Expand Down