This repository was archived by the owner on Nov 11, 2025. It is now read-only.
Manifest V3 - #17
Merged
Merged
Conversation
migrate to manifest v3
make backgroundScript a class; move scripts to seperate folder
wendelin-as
marked this pull request as ready for review
January 17, 2024 11:52
ushi-as
suggested changes
Jan 22, 2024
background script non-static; etc.
ushi-as
suggested changes
Jan 23, 2024
ushi-as
left a comment
ushi-as
left a comment
Member
There was a problem hiding this comment.
Kleinkram noch, dann is super.
Co-authored-by: Martin Kalcher <martin.kalcher@aboutsource.net>
Co-authored-by: Martin Kalcher <martin.kalcher@aboutsource.net>
ushi-as
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
importstatements verwendet werdenHier umgesetzte Lösung:
trektor.js und das background script werden in eine Datei zusammengeführt. Diese wird im Manifest als background script und als service worker eingebunden.Das BackgroundScript ist jetzt eine Klasse. Es gibt für jeden Browser ein eigenes script als eine Art wrapper, was nur die Aufgabe hat, dieBackgroundScriptKlasse mit demtrektor-Objekt zu initialisieren. Das firefox.js script ist als background script eingebunden, das chromium script ist ein service worker. Firefox ignoriert dabei den nicht unterstützten service worker; Chromium ab Version 121 ignoriert das background script - in früheren Chromium-Versionen schlägt das Laden wegen des background scripts jedoch leider fehl.Die aktuell im snap store als latest/stable markierte Chromium-Version ist Version 120; 121 ist latest/beta; es sollte also nicht lange dauern bis Version 121 stable ist.