This repository was archived by the owner on Nov 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/5252 #3
Merged
Merged
Feature/5252 #3
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f5145fd
add button
wendelin-as 21ac52e
add button event handler
wendelin-as 424b073
add onload event handler
wendelin-as b29b123
fix button disappearing
wendelin-as bdc1c07
use querySelector and querySelectorAll
wendelin-as 8ee0078
use createElement instead of innerHTML
714d15b
remove duplicate code
879e0b3
fix margin of 'add to card' heading
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,28 @@ | ||
| //TODO: Code, der auf trello.com ausgeführt wird | ||
| function addButton(){ | ||
| const sidebar = document.querySelector(".window-sidebar") | ||
| const button = document.createElement('span'); | ||
| button.classList.add('button-link'); | ||
| button.addEventListener('click', onClick); | ||
| sidebar.prepend(button); | ||
|
|
||
| const buttonIcon = document.createElement('span'); | ||
| buttonIcon.classList.add('icon-sm', 'plugin-icon'); | ||
| buttonIcon.innerText = '+'; | ||
| button.append(buttonIcon); | ||
|
|
||
| const buttonText = document.createElement('span'); | ||
| buttonText.innerText = 'Toggl Task'; | ||
| button.append(buttonText); | ||
|
|
||
| sidebar.querySelectorAll(".mod-no-top-margin")[1].classList.remove("mod-no-top-margin") | ||
| } | ||
|
|
||
| function onClick(){ | ||
| alert("work in progress ;)") | ||
| } | ||
|
|
||
| window.addEventListener("pushstate", function(){ | ||
| if(window.location.pathname.startsWith("/c/")){ | ||
| addButton() | ||
| } | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das hier nimmt vom zweiten Element der Liste die Klasse weg. Ist das beabsichtigt oder meintest du das erste? Das wäre dann
...)[0]. Brauchts das überhaupt. Dermarginstört doch nicht oder?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das zweite ist schon richtig,
mod-no-top-marginsoll von der h3 entfernt werden, damit diese einen Abstand zum Button hatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aber innerhalb der sidebar der zweite? Der button kommt doch vor die erste
h3oder? Du machst jasidebar.querySelectorAll. Da bekommst du nur Elemente innerhalb der sidebar, nicht das da links.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, mir fällt gerade auf, dass es bei einigen Karten noch ein
.mod-no-top-marginin der sidebar gibt und bei einigen nicht...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaa ok. ich überlass die entscheidung dir. ich finds wie gesagt grad nicht so wichtig. wichtiger ist die funktionalität. hübsch machen, geht später immernoch.