Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Feature/5252 #3

Merged
8 commits merged into from
Jan 25, 2022
Merged

Feature/5252 #3

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f5145fd
add button
wendelin-as Jan 24, 2022
21ac52e
add button event handler
wendelin-as Jan 24, 2022
424b073
add onload event handler
wendelin-as Jan 25, 2022
b29b123
fix button disappearing
wendelin-as Jan 25, 2022
bdc1c07
use querySelector and querySelectorAll
wendelin-as Jan 25, 2022
8ee0078
use createElement instead of innerHTML
Jan 25, 2022
714d15b
remove duplicate code
Jan 25, 2022
879e0b3
fix margin of 'add to card' heading
Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions content_script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
function addButton(){
const sidebar = document.querySelector(".window-sidebar")
sidebar.innerHTML = "<span class='button-link' id='togglbtn'><span class='icon-sm plugin-icon'>+</span><span>Toggl Task</span></span>" + sidebar.innerHTML
const button = document.createElement('span');
button.classList.add('button-link');
button.addEventListener('click', onClick);
sidebar.prepend(button);

const buttonIcon = document.createElement('span');
buttonIcon.classList.add('icon-sm', 'plugin-icon');
buttonIcon.innerText = '+';
button.append(buttonIcon);

const buttonText = document.createElement('span');
buttonText.innerText = 'Toggl Task';
button.append(buttonText);

sidebar.querySelectorAll(".mod-no-top-margin")[1].classList.remove("mod-no-top-margin")

@ushi-as ushi-as Jan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das hier nimmt vom zweiten Element der Liste die Klasse weg. Ist das beabsichtigt oder meintest du das erste? Das wäre dann ...)[0]. Brauchts das überhaupt. Der margin stört doch nicht oder?

@ghost ghost Jan 25, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das zweite ist schon richtig, mod-no-top-margin soll von der h3 entfernt werden, damit diese einen Abstand zum Button hat

@ushi-as ushi-as Jan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aber innerhalb der sidebar der zweite? Der button kommt doch vor die erste h3 oder? Du machst ja sidebar.querySelectorAll. Da bekommst du nur Elemente innerhalb der sidebar, nicht das da links.

@ghost ghost Jan 25, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, mir fällt gerade auf, dass es bei einigen Karten noch ein .mod-no-top-margin in der sidebar gibt und bei einigen nicht...

@ushi-as ushi-as Jan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaa ok. ich überlass die entscheidung dir. ich finds wie gesagt grad nicht so wichtig. wichtiger ist die funktionalität. hübsch machen, geht später immernoch.

document.querySelector("#togglbtn").addEventListener("click", onClick)
Comment thread
ushi-as marked this conversation as resolved.
Outdated
}
Expand All @@ -13,4 +26,4 @@ window.addEventListener("pushstate", function(){
if(window.location.pathname.startsWith("/c/")){
addButton()
}
})
})