Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Use existing task annotations from card titles if present - #15

Merged
jonathanschlue-as merged 2 commits into
mainfrom
feature/integrate_preexisting_and_manually_named_tracking_task
Oct 5, 2022
Merged

Use existing task annotations from card titles if present#15
jonathanschlue-as merged 2 commits into
mainfrom
feature/integrate_preexisting_and_manually_named_tracking_task

Conversation

@jonathanschlue-as

Copy link
Copy Markdown
Contributor

No description provided.

@jonathanschlue-as jonathanschlue-as self-assigned this Oct 5, 2022

@aboutsimon aboutsimon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! wollte ich auch schon lange. hab's nicht ausprobiert, aber code LGTM, bis auf die mini änderung ;)

Comment thread background.js Outdated
const taskName = `${taskPrefix}_${card.idShort}`;
const cardTaskName = card.name.match(/(?<=#)[a-z0-9]+_[0-9]+/)?.[0];

var taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];
let taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];

wir sind ja modern ;)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe beide Fälle erfolgreich testen können:

  • Bisheriges Verhalten bleibt bestehen für Karten ohne Task im Titel
  • Für Karte mit Task im Title nutzt Trektor den bestehenden Namen

@jonathanschlue-as
jonathanschlue-as merged commit 83120ee into main Oct 5, 2022
@jonathanschlue-as
jonathanschlue-as deleted the feature/integrate_preexisting_and_manually_named_tracking_task branch October 5, 2022 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants