Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Use existing task annotations from card titles if present #15

Merged
jonathanschlue-as merged 2 commits into from
Oct 5, 2022
Merged

Use existing task annotations from card titles if present #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4bb2b
Use existing task annotations from card titles if present
jonathanschlue-as Oct 5, 2022
9cca78a
Use modern js variable declaration "let" instead of "var"
jonathanschlue-as Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,17 @@ async function addTask(cardId) {
throw new Error('Card has multiple project labels.');
}
const taskPrefix = taskPrefixes[0];
const taskName = `${taskPrefix}_${card.idShort}`;
const cardTaskName = card.name.match(/(?<=#)[a-z0-9]+_[0-9]+/)?.[0];

var taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];

@aboutsimon aboutsimon Oct 5, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];
let taskName = card.name.match(/(?<=#)[a-z0-9_-]+/)?.[0];

wir sind ja modern ;)

@jonathanschlue-as jonathanschlue-as Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe beide Fälle erfolgreich testen können:

  • Bisheriges Verhalten bleibt bestehen für Karten ohne Task im Titel
  • Für Karte mit Task im Title nutzt Trektor den bestehenden Namen


if (taskName === undefined) {
taskName = `${taskPrefix}_${card.idShort}`;

if (cardTaskName === undefined) {
await trektor.trelloGateway.updateCard(card.id, {
name: `${card.name} #${taskName}`,
});
} else if (cardTaskName !== taskName) {
throw new Error('Card name includes invalid tracking task.');
}

const workspaces = await trektor.togglGateway.getWorkspaces();

if (workspaces.length === 0) {
Expand Down